chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 1365733005: Split captive portal metrics out of SSLErrorClassification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up before review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/chrome_metrics_helper.cc ('K') | « chrome/browser/interstitials/security_interstitial_page.cc ('k') | chrome/browser/ssl/bad_clock_blocking_page.cc » ('j') | chrome/browser/ssl/bad_clock_blocking_page.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index c74fb7a28b4f7f7880b003ca314ad64a86833f5a..f49d34146ae24af656094f416ec04ac20ab0f3cd 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -172,8 +172,11 @@ SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(

reporting_info.extra_suffix = GetExtraMetricsSuffix();

reporting_info.rappor_prefix = GetRapporPrefix();

reporting_info.rappor_report_type = rappor::SAFEBROWSING_RAPPOR_TYPE;

- set_metrics_helper(new ChromeMetricsHelper(

- web_contents, request_url(), reporting_info, GetSamplingEventName()));

+ set_metrics_helper(

+ scoped_ptr<ChromeMetricsHelper>(

estark 2015/09/25 23:53:34 optional nit: you can also use make_scoped_ptr() t

felt 2015/09/27 20:08:15 Done.

+ new ChromeMetricsHelper(web_contents, request_url(), reporting_info,

+ GetSamplingEventName()))

+ .Pass());

metrics_helper()->RecordUserDecision(

security_interstitials::MetricsHelper::SHOW);

metrics_helper()->RecordUserInteraction(