runtime/vm/dart.cc - Issue 136563002: Landing: Write protect executable pages in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 136563002: Landing: Write protect executable pages in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Fixed typo and removed debug printing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart.cc

diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc

index 5cbfefad6cc486bcbb4cbd7e4d3a9f797fd338b0..a617e0fe047347f24a196e5e356ade8f9f542da5 100644

--- a/runtime/vm/dart.cc

+++ b/runtime/vm/dart.cc

@@ -130,6 +130,7 @@ const char* Dart::InitOnce(Dart_IsolateCreateCallback create,

}

#endif

PremarkingVisitor premarker(vm_isolate_);

+ vm_isolate_->heap()->WriteProtect(false);

vm_isolate_->heap()->IterateOldObjects(&premarker);

vm_isolate_->heap()->WriteProtect(true);

}

« runtime/vm/code_patcher.h ('K') | « runtime/vm/code_patcher.cc ('k') | runtime/vm/debugger_arm.cc » ('j') | runtime/vm/virtual_memory_linux.cc » ('J')