Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: runtime/vm/dart.cc

Issue 136563002: Landing: Write protect executable pages in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Fixed typo and removed debug printing Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/dart_api_state.h" 8 #include "vm/dart_api_state.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flags.h" 10 #include "vm/flags.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 Scanner::InitOnce(); 123 Scanner::InitOnce();
124 Object::CreateInternalMetaData(); 124 Object::CreateInternalMetaData();
125 CPUFeatures::InitOnce(); 125 CPUFeatures::InitOnce();
126 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64) 126 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
127 // Dart VM requires at least SSE2. 127 // Dart VM requires at least SSE2.
128 if (!CPUFeatures::sse2_supported()) { 128 if (!CPUFeatures::sse2_supported()) {
129 return "SSE2 is required."; 129 return "SSE2 is required.";
130 } 130 }
131 #endif 131 #endif
132 PremarkingVisitor premarker(vm_isolate_); 132 PremarkingVisitor premarker(vm_isolate_);
133 vm_isolate_->heap()->WriteProtect(false);
133 vm_isolate_->heap()->IterateOldObjects(&premarker); 134 vm_isolate_->heap()->IterateOldObjects(&premarker);
134 vm_isolate_->heap()->WriteProtect(true); 135 vm_isolate_->heap()->WriteProtect(true);
135 } 136 }
136 // There is a planned and known asymmetry here: We enter one scope for the VM 137 // There is a planned and known asymmetry here: We enter one scope for the VM
137 // isolate so that we can allocate the "persistent" scoped handles for the 138 // isolate so that we can allocate the "persistent" scoped handles for the
138 // predefined API values (such as Dart_True, Dart_False and Dart_Null). 139 // predefined API values (such as Dart_True, Dart_False and Dart_Null).
139 Dart_EnterScope(); 140 Dart_EnterScope();
140 Api::InitHandles(); 141 Api::InitHandles();
141 142
142 Isolate::SetCurrent(NULL); // Unregister the VM isolate from this thread. 143 Isolate::SetCurrent(NULL); // Unregister the VM isolate from this thread.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 return predefined_handles_->handles_.AllocateScopedHandle(); 271 return predefined_handles_->handles_.AllocateScopedHandle();
271 } 272 }
272 273
273 274
274 bool Dart::IsReadOnlyHandle(uword address) { 275 bool Dart::IsReadOnlyHandle(uword address) {
275 ASSERT(predefined_handles_ != NULL); 276 ASSERT(predefined_handles_ != NULL);
276 return predefined_handles_->handles_.IsValidScopedHandle(address); 277 return predefined_handles_->handles_.IsValidScopedHandle(address);
277 } 278 }
278 279
279 } // namespace dart 280 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698