runtime/vm/code_patcher.h - Issue 136563002: Landing: Write protect executable pages in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_patcher.h

Issue 136563002: Landing: Write protect executable pages in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Fixed typo and removed debug printing Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_patcher.h

diff --git a/runtime/vm/code_patcher.h b/runtime/vm/code_patcher.h

index 0a7410fbecd1746b912a85be0203b5cff74c1194..4ff3dfb9493866f82ad02697b8b1b9baca3f9f41 100644

--- a/runtime/vm/code_patcher.h

+++ b/runtime/vm/code_patcher.h

@@ -22,6 +22,17 @@ class RawICData;

class RawObject;

class String;

+class WritableInstructionsScope : public ValueObject {

+ public:

+ WritableInstructionsScope(uword address, intptr_t size);

+ ~WritableInstructionsScope();

+ private:

+ uword address_;

+ intptr_t size_;

srdjan 2014/01/16 17:38:12 Both can be const. Please add a brief comment abou

Florian Schneider 2014/01/17 10:46:59 Done.

+};

class CodePatcher : public AllStatic {

public:

// Dart static calls have a distinct, machine-dependent code pattern.

« runtime/vm/assembler.cc ('K') | « runtime/vm/code_generator.cc ('k') | runtime/vm/code_patcher.cc » ('j') | runtime/vm/virtual_memory_linux.cc » ('J')