Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1364763002: Revert of roll_dep: Avoid large commit messages by providing the log as a link (Closed)

Created:
5 years, 3 months ago by M-A Ruel
Modified:
5 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of roll_dep: Avoid large commit messages by providing the log as a link (patchset #1 id:1 of https://codereview.chromium.org/1257233006/ ) Reason for revert: Blink merge is done, blink people won't have to use it anymore. Original issue's description: > roll_dep: Avoid large commit messages by providing the log as a link > > The majority of chromium projects are on googlesource.com, which can > display a range of commits on the web. Use this feature instead of > dumping logs into the commit message. > > Particularly, this avoids creating large commit messages as these logs > sometimes contain upwards of 50 commits. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296184 TBR=jochen@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M roll_dep.py View 2 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
Created Revert of roll_dep: Avoid large commit messages by providing the log as a link
5 years, 3 months ago (2015-09-23 13:45:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364763002/1
5 years, 3 months ago (2015-09-23 13:45:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296840
5 years, 3 months ago (2015-09-23 13:45:53 UTC) #3
spang
On 2015/09/23 13:45:53, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 3 months ago (2015-09-23 15:09:39 UTC) #4
M-A Ruel
On 2015/09/23 15:09:39, spang wrote: > On 2015/09/23 13:45:53, commit-bot: I haz the power wrote: ...
5 years, 3 months ago (2015-09-23 16:33:21 UTC) #5
spang
On 2015/09/23 16:33:21, M-A Ruel wrote: > On 2015/09/23 15:09:39, spang wrote: > > On ...
5 years, 3 months ago (2015-09-23 17:13:41 UTC) #6
spang
5 years, 3 months ago (2015-09-23 17:27:12 UTC) #7
Message was sent while issue was closed.
On 2015/09/23 17:13:41, spang wrote:
> On 2015/09/23 16:33:21, M-A Ruel wrote:
> > On 2015/09/23 15:09:39, spang wrote:
> > > On 2015/09/23 13:45:53, commit-bot: I haz the power wrote:
> > > > Committed patchset #1 (id:1) as
> > > > http://src.chromium.org/viewvc/chrome?view=rev&revision=296840
> > > 
> > > My patch had nothing to do with blink, but with trace-viewer (now
catapult)
> > and
> > > the fact that in the old (and now reverted) state, the signal/noise ratio
> for
> > > roll commit messages is basically zero. In fact reverting removes the most
> > > useful part (the googlesource link) since merely clicking on it verifies
the
> > git
> > > hash is correct.
> > > 
> > > So I don't think this was properly handled. Is there an actual reason to
> > revert?
> > 
> > Yes, next time please ensure you look at git log/blame. Also the rationale
for
> > the CL wasn't obvious, Jochen is not working on catapult so I couldn't see
any
> > obvious connection there. Not as "I own the code" but more as "let's get
input
> > first".
> 
> I definitely looked at the blame, however you were on vacation.
> 
> If you look our most active deps, none of them include a log. So I would say
> this tool is out of whack with the rest of the project's gardening practices. 
> 

To be specific, those that don't include: blink, v8, webrtc, angle

skia is a notable exception.


> > 
> > In that case I'm happy to bring the "skip descriptions for project X and Y"
> but
> > not as a blanket switch over. The link is nice, I just hadn't time to add it
> > first and reverting was easier at that point.

Powered by Google App Engine
This is Rietveld 408576698