Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1257233006: roll_dep: Avoid large commit messages by providing the log as a link (Closed)

Created:
5 years, 4 months ago by spang
Modified:
5 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

roll_dep: Avoid large commit messages by providing the log as a link The majority of chromium projects are on googlesource.com, which can display a range of commits on the web. Use this feature instead of dumping logs into the commit message. Particularly, this avoids creating large commit messages as these logs sometimes contain upwards of 50 commits. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M roll_dep.py View 2 chunks +20 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
spang
5 years, 4 months ago (2015-07-31 06:36:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-31 07:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257233006/1
5 years, 4 months ago (2015-07-31 15:48:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296184
5 years, 4 months ago (2015-07-31 15:51:08 UTC) #6
M-A Ruel
What's the problem with a 50 lines CL description? There's no problem in having both.
5 years, 4 months ago (2015-08-24 14:19:31 UTC) #7
spang
On 2015/08/24 14:19:31, M-A Ruel wrote: > What's the problem with a 50 lines CL ...
5 years, 3 months ago (2015-08-28 17:01:44 UTC) #8
M-A Ruel
On 2015/08/28 17:01:44, spang wrote: > On 2015/08/24 14:19:31, M-A Ruel wrote: > > What's ...
5 years, 3 months ago (2015-09-23 13:45:10 UTC) #9
M-A Ruel
5 years, 3 months ago (2015-09-23 13:45:28 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1364763002/ by maruel@chromium.org.

The reason for reverting is: Blink merge is done, blink people won't have to use
it anymore..

Powered by Google App Engine
This is Rietveld 408576698