Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1364613004: cvox2: Fix a typo causing the wrong variable to be referenced. (Closed)

Created:
5 years, 3 months ago by Peter Lundblad
Modified:
5 years, 3 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, dtseng+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nobrailleautostartintests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cvox2: Fix a typo causing the wrong variable to be referenced. Follow up to https://codereview.chromium.org/1326363002, making that change have the desirved effect. R=dtseng@chromium.org BUG=525649 Committed: https://crrev.com/c4a855eae3549d5ff697be4d1ea7274071c52391 Cr-Commit-Position: refs/heads/master@{#350589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
Peter Lundblad
5 years, 3 months ago (2015-09-23 13:39:41 UTC) #1
Peter Lundblad
I tried playing with closure compiler options to catch this, but it seems like assignments ...
5 years, 3 months ago (2015-09-23 13:43:07 UTC) #2
David Tseng
lgtm
5 years, 3 months ago (2015-09-23 15:46:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364613004/1
5 years, 3 months ago (2015-09-23 15:46:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/111099)
5 years, 3 months ago (2015-09-23 16:00:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364613004/1
5 years, 3 months ago (2015-09-24 16:38:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 17:14:43 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 17:15:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4a855eae3549d5ff697be4d1ea7274071c52391
Cr-Commit-Position: refs/heads/master@{#350589}

Powered by Google App Engine
This is Rietveld 408576698