Don't autostart Chromevox in tests when a braille display is connected.

Don't autostart Chromevox in tests when a braille display is connected.

This causes flake during local test runs (for those who use braille when
developing) and since bots don't generally have braille displays
connected, autostarting in tests doesn't add any value.

R=dmazzoni@chromium.org
BUG=None

Committed: https://crrev.com/cf1d08f49704fbbef3e94d7f1e7b538c1e610083
Cr-Commit-Position: refs/heads/master@{#351043}

[Peter Lundblad, 2015-09-25 08:29:33]

Friendly ping.

[dmazzoni, 2015-09-25 17:20:59]

lgtm

https://codereview.chromium.org/1354143005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/1354143005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:100: if
(command_line->HasSwitch(switches::kTestType))
Does this only work when the test is run in a subprocess? What if the test
target is run with --single-process so that the test is launched in the same
process as the test runner? I wonder if there's some other way to determine this
is part of a test.

[Peter Lundblad, 2015-09-28 08:34:22]

dmazzoni@chromium.org writes:
> lgtm
> 
> 
> 
> 
>
https://codereview.chromium.org/1354143005/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/accessibility/accessibility_manager.cc
> (right):
> 
>
https://codereview.chromium.org/1354143005/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/accessibility/accessibility_manager.cc:100: if
> (command_line->HasSwitch(switches::kTestType))
> Does this only work when the test is run in a subprocess? 

No, this flag is added to the command line of the current
process by InProcessBrowserTest::PrepareTestCommandLine
which, AFAICT, is called before BrowserMain is called.

> What if the
> test target is run with --single-process so that the test is launched in
> the same process as the test runner?

Tested, confirmed it has the desired effect.

>  I wonder if there's some other way
> to determine this is part of a test.

I did so as well, but found a bunch of other places in the code that checks
this as well.

> https://codereview.chromium.org/1354143005/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2015-09-28 08:35:06]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2015-09-28 08:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354143005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354143005/20001

[commit-bot: I haz the power, 2015-09-28 09:19:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-28 09:20:02]

Patchset 2 (id:??) landed as
https://crrev.com/cf1d08f49704fbbef3e94d7f1e7b538c1e610083
Cr-Commit-Position: refs/heads/master@{#351043}