Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1326363002: Reinstantiate EditableTextHandler instance on focus change. (Closed)

Created:
5 years, 3 months ago by David Tseng
Modified:
5 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reinstantiate EditableTextHandler instance on focus change. BUG=525649 Committed: https://crrev.com/9f600b5410929790c6b8f452f6ad42d8b52d8b46 Cr-Commit-Position: refs/heads/master@{#348410}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 2 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
David Tseng
5 years, 3 months ago (2015-09-08 23:28:06 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/1326363002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js (right): https://codereview.chromium.org/1326363002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#newcode552 chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:552: // Ignore the first text selection changed event ...
5 years, 3 months ago (2015-09-10 18:46:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326363002/1
5 years, 3 months ago (2015-09-11 16:16:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 16:44:59 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f600b5410929790c6b8f452f6ad42d8b52d8b46 Cr-Commit-Position: refs/heads/master@{#348410}
5 years, 3 months ago (2015-09-11 16:45:33 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f600b5410929790c6b8f452f6ad42d8b52d8b46
Cr-Commit-Position: refs/heads/master@{#348410}

Powered by Google App Engine
This is Rietveld 408576698