Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 136443008: Move preferred scrollbar style preference change listening from renderer to browser, 2 of 3. (Closed)

Created:
6 years, 11 months ago by Robert Sesek
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move preferred scrollbar style preference change listening from renderer to browser, 2 of 3. This adds the preference observer to the browser and starts sending the parameter to the renderer over IPC when it changes. Blink will not use this until part 3 lands. BUG=306348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246635

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix iOS compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -36 lines) Patch
M content/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/theme_helper_mac.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/theme_helper_mac.mm View 1 7 chunks +54 lines, -25 lines 0 comments Download
M content/common/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Robert Sesek
Part 1: https://codereview.chromium.org/142033003/ Part 3: https://codereview.chromium.org/136333009/
6 years, 11 months ago (2014-01-17 21:35:53 UTC) #1
Avi (use Gerrit)
LGTM
6 years, 11 months ago (2014-01-20 22:53:33 UTC) #2
Robert Sesek
+tsepez for content/common/view_messages.h +jamesr to approve OWNERS for introducing a DEPS change from content on ...
6 years, 11 months ago (2014-01-22 23:00:24 UTC) #3
jamesr
DEPS change lgtm
6 years, 11 months ago (2014-01-22 23:02:02 UTC) #4
Tom Sepez
Messages LGTM.
6 years, 11 months ago (2014-01-22 23:04:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/136443008/60001
6 years, 11 months ago (2014-01-23 14:02:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, net_unittests, sql_unittests, ...
6 years, 11 months ago (2014-01-23 14:39:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/136443008/60001
6 years, 11 months ago (2014-01-23 14:41:22 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, net_unittests, sql_unittests, ...
6 years, 11 months ago (2014-01-23 15:09:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/136443008/590001
6 years, 11 months ago (2014-01-23 15:25:31 UTC) #10
commit-bot: I haz the power
Failed to get patchset properties (patchset not found?)
6 years, 11 months ago (2014-01-23 15:49:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/136443008/760001
6 years, 11 months ago (2014-01-23 15:51:30 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 17:49:14 UTC) #13
Message was sent while issue was closed.
Change committed as 246635

Powered by Google App Engine
This is Rietveld 408576698