Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: ui/base/cocoa/controls/hyperlink_text_view.h

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | ui/base/cocoa/controls/hyperlink_text_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/cocoa/controls/hyperlink_text_view.h
diff --git a/ui/base/cocoa/controls/hyperlink_text_view.h b/ui/base/cocoa/controls/hyperlink_text_view.h
index f04ad40b1823aee1b60fa85e0c5e2b39aec6b907..affe648d206bc012a42a43d04563a24d2867fc65 100644
--- a/ui/base/cocoa/controls/hyperlink_text_view.h
+++ b/ui/base/cocoa/controls/hyperlink_text_view.h
@@ -26,10 +26,9 @@ UI_BASE_EXPORT
withFont:(NSFont*)font
messageColor:(NSColor*)messageColor;
-// Marks a |range| within the given message as link, associating it with
-// a |name| that is passed to the delegate's textView:clickedOnLink:atIndex:.
+// Marks a |range| within the given message as link.
- (void)addLinkRange:(NSRange)range
- withName:(id)name
+ withURL:(NSString*)url
noyau (Ping after 24h) 2015/09/24 07:54:05 Driving by: Is there a reason why this is a string
Avi (use Gerrit) 2015/09/24 14:24:57 This is a core Cocoa UI class, and everything else
linkColor:(NSColor*)linkColor;
// This is NO (by default) if the view rejects first responder status.
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | ui/base/cocoa/controls/hyperlink_text_view.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698