chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm ('k') | ui/base/cocoa/controls/hyperlink_text_view.h » ('j') | ui/base/cocoa/controls/hyperlink_text_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index 5f9cff247b08b7fe705d222c4a0facbc1c5cb7a6..8d5b190370cef3442775275ca930a21e92d8ea44 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -2126,6 +2126,10 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {

GURL url(GURL(url_formatter::FixupURL(

base::SysNSStringToUTF8([urls objectAtIndex:0]), std::string())));

+ // If the URL isn't valid, don't bother.

+ if (!url.is_valid())

+ return;

[self openURL:&url inView:view at:point];

}