Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2848)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm ('k') | chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm » ('j') | ui/base/cocoa/controls/hyperlink_text_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index 71210374cb6908bcc5492279daabca375b54e6e3..50e3d415497dceaca850a8900f4218113ccf8c96 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -175,7 +175,7 @@ NSTextView* BuildFixedWidthTextViewWithLink(
withFont:[NSFont labelFontOfSize:kTextFontSize]
messageColor:[NSColor blackColor]];
[text_view addLinkRange:NSMakeRange(link_offset, [link length])
- withName:@""
+ withURL:@"about:blank" // using a link here is bad ui
linkColor:link_color];
// Removes the underlining from the link.
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm ('k') | chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm » ('j') | ui/base/cocoa/controls/hyperlink_text_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698