chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm ('k') | chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm » ('j') | ui/base/cocoa/controls/hyperlink_text_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

index 04ee8c827fd7cee55a8a8d40a300d507204d04de..7212b9de5492d5b798a4e6cd4bc4ea83cce909e4 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

@@ -105,7 +105,7 @@ using namespace password_manager::mac::ui;

NSColor* linkColor =

gfx::SkColorToCalibratedNSColor(chrome_style::GetLinkColor());

[titleView_ addLinkRange:titleBrandLinkRange

- withName:@""

+ withURL:@"about:blank" // using a link here is bad ui

linkColor:linkColor];

[titleView_.get() setDelegate:self];