chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 1363763002: Move duplicate code for exiting fullscreen to ChromeActivity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 1363763002: Move duplicate code for exiting fullscreen to ChromeActivity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 5179ef25fe0bc68b4618716b3b3b6953419ece91..7ee73eaca41b007473a6f76282adde1d299b4f48 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -993,14 +993,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

return true;

}

- if (isFullscreenVideoPlaying()) {

- ContentVideoView.getContentVideoView().exitFullscreen(false);

- Log.i(TAG, "handleBackPressed() - exit fullscreen video");

- return true;

- }

- if (getFullscreenManager().getPersistentFullscreenMode()) {

- getFullscreenManager().setPersistentFullscreenMode(false);

+ if (exitFullscreenIfShowing()) {

Log.i(TAG, "handleBackPressed() - exit fullscreen");

return true;

}