Reserve capacity for static strings HashMap.

Reserve capacity for static strings HashMap.

The CoreInitialier and ModulesInitializer classes and now reserve the static strings HashMap capacity beforehand reducing the unneeded table re-creation and re-hashing of the contained elements at start up.

This patch also moves reservation capacity for QualifiedNames to CoreInitialier so that all the static strings initialization logic is encapsulated there.

Committed: https://crrev.com/65d5daa3dfa766ea89b2634d986488044659576f
Cr-Commit-Position: refs/heads/master@{#351548}

[tkent, 2015-09-28 00:11:16]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2015-09-28 00:11:17]

https://codereview.chromium.org/1363653006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/Init.cpp (right):

https://codereview.chromium.org/1363653006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/Init.cpp:84: // TODO: We should generate static
strings initialization code.
TODO needs your name.
  TODO(mikhail.pozdnyakov@intel.com): ...

Note that it doesn't mean you should fix it.

https://codereview.chromium.org/1363653006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/Init.cpp:129: WTF::StringStatics::init();
This needs to be called before QualifiedName::init*() because of starAtom.

[Mikhail, 2015-09-28 08:39:34]

https://codereview.chromium.org/1363653006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/Init.cpp (right):

https://codereview.chromium.org/1363653006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/Init.cpp:84: // TODO: We should generate static
strings initialization code.
On 2015/09/28 00:11:17, tkent wrote:
> TODO needs your name.
>   mailto:TODO(mikhail.pozdnyakov@intel.com): ...
> 
> Note that it doesn't mean you should fix it.
> 

Done.

https://codereview.chromium.org/1363653006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/Init.cpp:129: WTF::StringStatics::init();
On 2015/09/28 00:11:16, tkent wrote:
> This needs to be called before QualifiedName::init*() because of starAtom.

Done.

[tkent, 2015-09-28 23:39:39]

Many tests still fail.

http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...

ASSERTION FAILED: !string->isStatic() || result->isStatic()
../../third_party/WebKit/Source/wtf/text/AtomicString.cpp(60) : WTF::StringImpl
*WTF::AtomicStringTable::addStringImpl(WTF::StringImpl *)

#0 0x000000b94d1b base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fc1626f7cb0 <unknown>
#2 0x00000198d126 WTF::AtomicStringTable::addStringImpl()
#3 0x00000198cffd WTF::AtomicString::addSlowCase()
#4 0x0000026db8c6 blink::QualifiedName::createStatic()
#5 0x00000314c42c blink::XMLNSNames::init()
#6 0x00000288e1aa blink::CoreInitializer::init()
#7 0x00000219ce4f blink::ModulesInitializer::init()
#8 0x000002131b4a blink::initializeWithoutV8()
#9 0x000002131871 blink::initialize()

[Mikhail, 2015-09-30 06:23:35]

Patchset #4 (id:60001) has been deleted

[Mikhail, 2015-09-30 06:23:48]

Patchset #3 (id:40001) has been deleted

[Mikhail, 2015-09-30 07:25:47]

On 2015/09/28 23:39:39, tkent wrote:
> Many tests still fail.
> 
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...
> 
> ASSERTION FAILED: !string->isStatic() || result->isStatic()
> ../../third_party/WebKit/Source/wtf/text/AtomicString.cpp(60) :
WTF::StringImpl
> *WTF::AtomicStringTable::addStringImpl(WTF::StringImpl *)
> 
> #0 0x000000b94d1b base::debug::(anonymous namespace)::StackDumpSignalHandler()
> #1 0x7fc1626f7cb0 <unknown>
> #2 0x00000198d126 WTF::AtomicStringTable::addStringImpl()
> #3 0x00000198cffd WTF::AtomicString::addSlowCase()
> #4 0x0000026db8c6 blink::QualifiedName::createStatic()
> #5 0x00000314c42c blink::XMLNSNames::init()
> #6 0x00000288e1aa blink::CoreInitializer::init()
> #7 0x00000219ce4f blink::ModulesInitializer::init()
> #8 0x000002131b4a blink::initializeWithoutV8()
> #9 0x000002131871 blink::initialize()

Fixed with making the strings in WTF::StringStatics::init() actually static. The
positive side effect is that now this function does not need to be invoked from
core init().

[tkent, 2015-09-30 08:42:49]

lgtm

[Mikhail, 2015-09-30 12:43:11]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2015-09-30 12:43:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1363653006/#ps100001
(title: "Fixed the deduced string length (exclude NULL terminator)")

[commit-bot: I haz the power, 2015-09-30 12:44:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363653006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363653006/100001

[commit-bot: I haz the power, 2015-09-30 14:09:20]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-09-30 14:10:05]

Patchset 4 (id:??) landed as
https://crrev.com/65d5daa3dfa766ea89b2634d986488044659576f
Cr-Commit-Position: refs/heads/master@{#351548}