third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl - Issue 1363653006: Reserve capacity for static strings HashMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl

Issue 1363653006: Reserve capacity for static strings HashMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the deduced string length (exclude NULL terminator) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl

index c9098ca9fe489eb232575ff8ae690bfe9b296443..ed0c03160f41f7ef42c01dc3f783c5c1a13ca419 100644

--- a/third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/MakeNames.cpp.tmpl

@@ -17,9 +17,7 @@ namespace {{namespace}}Names {

using namespace WTF;

-const int k{{suffix}}NameCount = {{entries|length}};

-void* {{suffix}}NamesStorage[k{{suffix}}NameCount * ((sizeof(AtomicString) + sizeof(void *) - 1) / sizeof(void *))];

+void* {{suffix}}NamesStorage[{{namespace}}{{suffix}}NamesCount * ((sizeof(AtomicString) + sizeof(void *) - 1) / sizeof(void *))];

{% for entry in entries|sort(attribute='name', case_sensitive=True) %}

{% filter enable_conditional(entry.Conditional) %}

« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/MakeNames.h.tmpl » ('j') | no next file with comments »