Reserve capacity for static strings HashMap.

third_party/WebKit/Source/core/Init.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 58 matching lines @@
         return;
     isRegistered = true;
 
     Document::registerEventFactory(EventFactory::create());
 }
 
 void CoreInitializer::init()
 {
     ASSERT(!m_isInited);
     m_isInited = true;
+    // Note: in order to add core static strings for a new module (1)
+    // the value of 'coreStaticStringsCount' must be updated with the
+    // added strings count, (2) if the added strings are quialified names
+    // the 'qualifiedNamesCount' must be updated as well, (3) the strings
+    // 'init()' function call must be added.
+    // TODO: We should generate static strings initialization code.

[tkent, 2015/09/28 00:11:17]

TODO needs your name.
  TODO(mikhail.pozdnyakov@intel.com): ...

Note that it doesn't mean you should fix it.

[Mikhail, 2015/09/28 08:39:34]

Done.

+    const unsigned qualifiedNamesCount = HTMLNames::HTMLTagsCount + HTMLNames::HTMLAttrsCount
+        + MathMLNames::MathMLTagsCount + MathMLNames::MathMLAttrsCount
+        + SVGNames::SVGTagsCount + SVGNames::SVGAttrsCount
+        + XLinkNames::XLinkAttrsCount
+        + XMLNSNames::XMLNSAttrsCount
+        + XMLNames::XMLAttrsCount;
+
+    QualifiedName::initAndReserveCapacityForSize(qualifiedNamesCount);
+
+    const unsigned coreStaticStringsCount = qualifiedNamesCount
+        + EventNames::EventNamesCount
+        + EventTargetNames::EventTargetNamesCount
+        + EventTypeNames::EventTypeNamesCount
+        + FetchInitiatorTypeNames::FetchInitiatorTypeNamesCount
+        + FontFamilyNames::FontFamilyNamesCount
+        + HTMLTokenizerNames::HTMLTokenizerNamesCount
+        + InputTypeNames::InputTypeNamesCount
+        + MediaFeatureNames::MediaFeatureNamesCount
+        + MediaTypeNames::MediaTypeNamesCount;
+
+    StringImpl::reserveStaticStringsCapacityForSize(coreStaticStringsCount + StringImpl::allStaticStrings().size());
 
     HTMLNames::init();
     SVGNames::init();
     XLinkNames::init();
     MathMLNames::init();
     XMLNSNames::init();
     XMLNames::init();
 
     EventNames::init();
     EventTargetNames::init();
     EventTypeNames::init();
     FetchInitiatorTypeNames::init();
     FontFamilyNames::init();
     HTMLTokenizerNames::init();
     InputTypeNames::init();
     MediaFeatureNames::init();
     MediaTypeNames::init();
 
     CSSPrimitiveValue::initUnitTable();
     CSSParserTokenRange::initStaticEOFToken();
 
     // It would make logical sense to do this in WTF::initialize() but there are
     // ordering dependencies, e.g. about "xmlns".
     WTF::StringStatics::init();

[tkent, 2015/09/28 00:11:16]

This needs to be called before QualifiedName::init*() because of starAtom.

[Mikhail, 2015/09/28 08:39:34]

Done.

 
     StyleChangeExtraData::init();
 
-    QualifiedName::init();
     EventTracer::initialize();
     KURL::initialize();
     SecurityPolicy::init();
 
     registerEventFactory();
 
     StringImpl::freezeStaticStrings();
 
     // Creates HTMLParserThread::shared and ScriptStreamerThread::shared, but
     // does not start the threads.
     HTMLParserThread::init();
     ScriptStreamerThread::init();
 }
 
 void CoreInitializer::shutdown()
 {
     // Make sure we stop the HTMLParserThread before Platform::current() is
     // cleared.
     HTMLParserThread::shutdown();
 }
 
 } // namespace blink