build/android/incremental_install/installer.py - Issue 1363423002: GN: Don't automatically grant permissions when installing incremental apks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/incremental_install/installer.py

Issue 1363423002: GN: Don't automatically grant permissions when installing incremental apks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/incremental_install/installer.py

diff --git a/build/android/incremental_install/installer.py b/build/android/incremental_install/installer.py

index 1d70335491e3016a155c6763e8ff25bd9817df31..bc0954b524aababe8dba37bd48b9691840d84cb0 100755

--- a/build/android/incremental_install/installer.py

+++ b/build/android/incremental_install/installer.py

@@ -125,9 +125,9 @@ def main():

for split_glob in args.splits:

splits.extend((f for f in glob.glob(split_glob)))

device.InstallSplitApk(args.apk_path, splits, reinstall=True,

- allow_cached_props=True)

+ allow_cached_props=True, permissions=())

else:

- device.Install(args.apk_path, reinstall=True)

+ device.Install(args.apk_path, reinstall=True, permissions=())

install_timer.Stop(log=False)

# Push .so and .dex files to the device (if they have changed).

« no previous file with comments | « no previous file | no next file » | no next file with comments »