Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: ui/shell_dialogs/select_file_dialog_win.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/shell_dialogs/select_file_dialog_win.cc
diff --git a/ui/shell_dialogs/select_file_dialog_win.cc b/ui/shell_dialogs/select_file_dialog_win.cc
index a90c3bc1642e766d7b026d20a99ef109991ff064..fd0f025b49c308c96ae56728ded7c5ae029b673d 100644
--- a/ui/shell_dialogs/select_file_dialog_win.cc
+++ b/ui/shell_dialogs/select_file_dialog_win.cc
@@ -179,6 +179,7 @@ class SelectFileDialogImpl : public ui::SelectFileDialog,
const base::FilePath::StringType& default_extension,
gfx::NativeWindow owning_window,
void* params) override;
+ void CloseImpl() override;
private:
~SelectFileDialogImpl() override;
@@ -312,6 +313,10 @@ SelectFileDialogImpl::SelectFileDialogImpl(
get_save_file_name_impl_(get_save_file_name_impl) {
}
+void SelectFileDialogImpl::CloseImpl() {
+ NOTIMPLEMENTED();
+}
+
SelectFileDialogImpl::~SelectFileDialogImpl() {
}
« ui/shell_dialogs/select_file_dialog.h ('K') | « ui/shell_dialogs/select_file_dialog_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698