ui/shell_dialogs/select_file_dialog.h - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/shell_dialogs/select_file_dialog.h

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view_focus_uitest.cc ('K') | « chrome/browser/ui/views/select_file_dialog_extension.cc ('k') | ui/shell_dialogs/select_file_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/shell_dialogs/select_file_dialog.h

diff --git a/ui/shell_dialogs/select_file_dialog.h b/ui/shell_dialogs/select_file_dialog.h

index b5c877b541c361230604320952c5503d91382d50..e7ec4f9035886bd268e54e31142ab607a3c194f0 100644

--- a/ui/shell_dialogs/select_file_dialog.h

+++ b/ui/shell_dialogs/select_file_dialog.h

@@ -170,6 +170,7 @@ class SHELL_DIALOGS_EXPORT SelectFileDialog

const base::FilePath::StringType& default_extension,

gfx::NativeWindow owning_window,

void* params);

+ void Close();

bool HasMultipleFileTypeChoices();

// Sets the global ShellDialogsDelegate. Defaults to NULL.

@@ -194,6 +195,8 @@ class SHELL_DIALOGS_EXPORT SelectFileDialog

gfx::NativeWindow owning_window,

void* params) = 0;

+ virtual void CloseImpl() = 0;

msw 2015/10/16 17:01:04 What's the point of splitting up Close and CloseIm

joone 2015/10/16 23:33:46 We don't need CloseImpl() so I removed it.

// Returns the global ShellDialogsDelegate instance if any.

ShellDialogsDelegate* GetShellDialogsDelegate();