Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: ui/shell_dialogs/select_file_dialog_mac.mm

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/shell_dialogs/select_file_dialog_mac.mm
diff --git a/ui/shell_dialogs/select_file_dialog_mac.mm b/ui/shell_dialogs/select_file_dialog_mac.mm
index 9a4a5fd386792122f0c7d6a3ad1832d97f5f26a9..67c1086c8f7fee0a60d0cca0e1e54d3eaf297b2d 100644
--- a/ui/shell_dialogs/select_file_dialog_mac.mm
+++ b/ui/shell_dialogs/select_file_dialog_mac.mm
@@ -85,6 +85,7 @@ class SelectFileDialogImpl : public ui::SelectFileDialog {
const base::FilePath::StringType& default_extension,
gfx::NativeWindow owning_window,
void* params) override;
+ void CloseImpl() override;
private:
~SelectFileDialogImpl() override;
@@ -119,6 +120,10 @@ SelectFileDialogImpl::SelectFileDialogImpl(Listener* listener,
initWithSelectFileDialogImpl:this]) {
}
+void SelectFileDialogImpl::CloseImpl() {
+ NOTIMPLEMENTED();
+}
+
bool SelectFileDialogImpl::IsRunning(gfx::NativeWindow parent_window) const {
return parents_.find(parent_window) != parents_.end();
}

Powered by Google App Engine
This is Rietveld 408576698