chrome/browser/ui/views/select_file_dialog_extension.h - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.h

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view_focus_uitest.cc ('K') | « chrome/browser/ui/views/frame/browser_view_focus_uitest.cc ('k') | chrome/browser/ui/views/select_file_dialog_extension.cc » ('j') | ui/shell_dialogs/select_file_dialog.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension.h

diff --git a/chrome/browser/ui/views/select_file_dialog_extension.h b/chrome/browser/ui/views/select_file_dialog_extension.h

index 8d70adda9e21df32bcc783b53d9954fa2b0d146d..535d95481f3b34af1b415ccd6eb1e4c418458aeb 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension.h

+++ b/chrome/browser/ui/views/select_file_dialog_extension.h

@@ -73,6 +73,7 @@ class SelectFileDialogExtension

const base::FilePath::StringType& default_extension,

gfx::NativeWindow owning_window,

void* params) override;

+ void CloseImpl() override;

private:

friend class SelectFileDialogExtensionBrowserTest;