chrome/browser/ui/views/select_file_dialog_extension.cc - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view_focus_uitest.cc ('K') | « chrome/browser/ui/views/select_file_dialog_extension.h ('k') | ui/shell_dialogs/select_file_dialog.h » ('j') | ui/shell_dialogs/select_file_dialog.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc

index c31699be84ac0cc525c7d6645b1974923fb8c63f..7006c86d3875ae7a36607cc5eececd3f5030f568 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension.cc

@@ -177,6 +177,10 @@ SelectFileDialogExtension::SelectFileDialogExtension(

params_(NULL) {

}

+void SelectFileDialogExtension::CloseImpl() {

+ NOTIMPLEMENTED();

SelectFileDialogExtension::~SelectFileDialogExtension() {

if (extension_dialog_.get())

extension_dialog_->ObserverDestroyed();