build/sanitizers/lsan_suppressions.cc - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/sanitizers/lsan_suppressions.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc » ('j') | chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/sanitizers/lsan_suppressions.cc

diff --git a/build/sanitizers/lsan_suppressions.cc b/build/sanitizers/lsan_suppressions.cc

index d1c9d22cac3850eb94ecd77b2c45c3268dcce3c5..84b44532fdfe522628dc6971d2f3a69404500e33 100644

--- a/build/sanitizers/lsan_suppressions.cc

+++ b/build/sanitizers/lsan_suppressions.cc

@@ -54,6 +54,9 @@ char kLSanDefaultSuppressions[] =

// Leaks in swrast_dri.so. http://crbug.com/540042

"leak:swrast_dri.so\n"

+// Leaks in GtkFileChooserDialog. http://crbug.com/537468

+"leak:libglib-2.0\n"

msw 2015/10/16 17:01:03 I wonder if this is too wide of a suppression. Wou

joone 2015/10/16 23:33:46 How about adding interactive_ui_tests to the suppr

// ================ Leaks in Chromium code ================

// PLEASE DO NOT ADD SUPPRESSIONS FOR NEW LEAKS.

// Instead, commits that introduce memory leaks should be reverted. Suppressing