Add BrowserSelectFileDialogTest.OpenCloseFileDialog

build/sanitizers/lsan_suppressions.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains the default suppressions for LeakSanitizer.
 // You can also pass additional suppressions via LSAN_OPTIONS:
 // LSAN_OPTIONS=suppressions=/path/to/suppressions. Please refer to
 // http://dev.chromium.org/developers/testing/leaksanitizer for more info.
 
 #if defined(LEAK_SANITIZER)
@@ skipping 36 matching lines @@
 
 // xrandr leak. http://crbug.com/119677
 "leak:XRRFindDisplay\n"
 
 // http://crbug.com/431213, http://crbug.com/416665
 "leak:gin/object_template_builder.h\n"
 
 // Leaks in swrast_dri.so. http://crbug.com/540042
 "leak:swrast_dri.so\n"
 
+// Leaks in GtkFileChooserDialog. http://crbug.com/537468
+"leak:libglib-2.0\n"

[msw, 2015/10/16 17:01:03]

I wonder if this is too wide of a suppression. Would this ignore any leaks of
memory allocated by glib (even if the fault was in our ownership/usage)? You
should ping someone familiar with lsan/glib.

[joone, 2015/10/16 23:33:46]

How about adding interactive_ui_tests to the suppression list?

+
 // ================ Leaks in Chromium code ================
 // PLEASE DO NOT ADD SUPPRESSIONS FOR NEW LEAKS.
 // Instead, commits that introduce memory leaks should be reverted. Suppressing
 // the leak is acceptable in some cases when reverting is impossible, i.e. when
 // enabling leak detection for the first time for a test target with
 // pre-existing leaks.
 
 // Small test-only leak in ppapi_unittests. http://crbug.com/258113
 "leak:ppapi::proxy::PPP_Instance_Private_ProxyTest_PPPInstancePrivate_Test\n"
 
 // http://crbug.com/322671
 "leak:content::SpeechRecognitionBrowserTest::SetUpOnMainThread\n"
 
 // http://crbug.com/355641
 "leak:TrayAccessibilityTest\n"
 
 // http://crbug.com/354644
 "leak:CertificateViewerUITest::ShowModalCertificateViewer\n"
 
 // http://crbug.com/356306
 "leak:content::SetProcessTitleFromCommandLine\n"
 
 // PLEASE READ ABOVE BEFORE ADDING NEW SUPPRESSIONS.
 
 // End of suppressions.
 ;  // Please keep this semicolon.
 
 #endif  // LEAK_SANITIZER