chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/sanitizers/lsan_suppressions.cc ('K') | « build/sanitizers/lsan_suppressions.cc ('k') | chrome/browser/ui/browser.h » ('j') | chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

diff --git a/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc b/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

index fd2d19e186429bb7cf02beb2a1a008ea120bef00..d705ae16b2a3c20e15e9f10b7ba4d692f734d6ff 100644

--- a/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

+++ b/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

@@ -94,6 +94,8 @@ class FakeSelectFileDialog : public ui::SelectFileDialog {

base::FilePath("/special/drive-user/root/test_dir"), 0, NULL);

}

+ void CloseImpl() override { NOTIMPLEMENTED(); }

bool IsRunning(gfx::NativeWindow owning_window) const override {

return false;

}