Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362953003: Fire window.onerror for uncaught IndexedDB errors (Closed)

Created:
5 years, 3 months ago by jsbell
Modified:
3 years, 5 months ago
Reviewers:
haraken, Mike West, cmumford
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire window.onerror for uncaught IndexedDB errors Capture the call stack when an IDBRequest is made, and if the request fails with an error, and the error is not prevented, then fire window.onerror (and worker's global onerror). Not part of the Indexed DB "v1" spec, but planned for v2 and already implemented in Firefox. BUG=302010

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Only grab full stack if console attached #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased #

Patch Set 7 : Rebased #

Patch Set 8 : Switch to SourceLocation #

Patch Set 9 : WIP Rebase; more test rebasing needed #

Patch Set 10 : Rebased #

Patch Set 11 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -88 lines) Patch
M third_party/WebKit/LayoutTests/resources/js-test.js View 1 2 3 4 5 6 4 chunks +20 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/error-attributes.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt View 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/getdatabasenames-failed-open.html View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-createObjectStore-exception-order.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/idbdatabase-deleteObjectStore-exception-order.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/index-multientry-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/lazy-index-population.html View 4 chunks +18 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/lazy-index-population-expected.txt View 4 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/request-event-propagation-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/error-causes-abort-by-default.js View 5 chunks +23 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/index-multientry.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-revert-on-abort.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-upgrades.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/metadata.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/objectstore-basics.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer.js View 1 2 3 4 5 6 7 8 9 8 chunks +14 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/odd-strings.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/persistence.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/request-continue-abort.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/request-event-propagation.js View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/transaction-abort.js View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/transaction-basics.js View 1 2 3 4 5 6 5 chunks +19 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/transaction-error.js View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/transaction-event-propagation.js View 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/unblocked-version-changes.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/resources/version-change-abort.js View 4 chunks +40 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/transaction-error-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/transaction-event-propagation-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/upgrade-transaction-lifecycle-backend-aborted.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/upgrade-transaction-lifecycle-microtasks.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/upgradeneeded-tests.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/version-change-abort-expected.txt View 2 chunks +15 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/window-onerror.html View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/indexeddb/window-onerror-prevented.html View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/ErrorEvent.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/DOMError.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DOMError.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jsbell
migrated from https://codereview.chromium.org/243523003/
5 years, 3 months ago (2015-09-23 17:37:32 UTC) #1
jsbell
No need to review this, just dusting off this CL. Pre-blink merge CL was https://codereview.chromium.org/243523003/ ...
4 years, 10 months ago (2016-02-05 00:12:02 UTC) #3
cmumford
lgtm
4 years, 9 months ago (2016-02-29 21:33:36 UTC) #4
haraken
bindings/ LGTM
4 years, 9 months ago (2016-02-29 23:24:49 UTC) #5
jsbell
Note to self: update to SourceLocation once https://codereview.chromium.org/2010603002/ is in
4 years, 7 months ago (2016-05-24 20:38:31 UTC) #6
jsbell
3 years, 5 months ago (2017-07-24 20:59:18 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698