Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362783004: Revert of [turbofan] Checking of input counts on node creation (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Checking of input counts on node creation (patchset #4 id:60001 of https://codereview.chromium.org/1347353003/ ) Reason for revert: [Sheriff] Breaks mips cross-compile: http://build.chromium.org/p/client.v8/builders/V8%20Mips%20-%20builder/builds/4315 Original issue's description: > [turbofan] Checking of input counts on node creation > > This required fixing bunch of tests with wrong input counts. > > Committed: https://crrev.com/260ec46efd74c45cdc4b156d95086b7de06621ad > Cr-Commit-Position: refs/heads/master@{#30877} TBR=bmeurer@chromium.org,mstarzinger@chromium.org,jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c602a91c1d40bbbde044ed1f72ca6470f60f07f7 Cr-Commit-Position: refs/heads/master@{#30878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -474 lines) Patch
M src/compiler/basic-block-instrumentor.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/graph.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/graph.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 12 chunks +147 lines, -123 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 15 chunks +48 lines, -33 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 2 chunks +13 lines, -15 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 4 chunks +15 lines, -25 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 38 chunks +122 lines, -133 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 18 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 4 chunks +28 lines, -16 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +21 lines, -9 lines 0 comments Download
M test/unittests/compiler/liveness-analyzer-unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [turbofan] Checking of input counts on node creation
5 years, 3 months ago (2015-09-23 08:01:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362783004/1
5 years, 3 months ago (2015-09-23 08:01:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362783004/1
5 years, 3 months ago (2015-09-23 08:02:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 08:02:30 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 08:02:52 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c602a91c1d40bbbde044ed1f72ca6470f60f07f7
Cr-Commit-Position: refs/heads/master@{#30878}

Powered by Google App Engine
This is Rietveld 408576698