Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: test/unittests/compiler/js-type-feedback-unittest.cc

Issue 1362783004: Revert of [turbofan] Checking of input counts on node creation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/js-type-feedback-unittest.cc
diff --git a/test/unittests/compiler/js-type-feedback-unittest.cc b/test/unittests/compiler/js-type-feedback-unittest.cc
index f3f1b733fc75462d0b31f8f0ce783de324ccffec..3f981f74accac054498c7d110d2839fc2635de81 100644
--- a/test/unittests/compiler/js-type-feedback-unittest.cc
+++ b/test/unittests/compiler/js-type-feedback-unittest.cc
@@ -84,9 +84,15 @@
Handle<Name> name = isolate()->factory()->InternalizeUtf8String(string);
const Operator* op = javascript()->LoadGlobal(name, feedback);
- Node* load =
- graph()->NewNode(op, context, global, vector, context,
- EmptyFrameState(), EmptyFrameState(), effect, control);
+ Node* load = graph()->NewNode(op, context, global, vector, context);
+ if (mode == JSTypeFeedbackSpecializer::kDeoptimizationEnabled) {
+ for (int i = 0; i < OperatorProperties::GetFrameStateInputCount(op);
+ i++) {
+ load->AppendInput(zone(), EmptyFrameState());
+ }
+ }
+ load->AppendInput(zone(), effect);
+ load->AppendInput(zone(), control);
Node* if_success = graph()->NewNode(common()->IfSuccess(), load);
return graph()->NewNode(common()->Return(), load, load, if_success);
}
« no previous file with comments | « test/unittests/compiler/js-context-relaxation-unittest.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698