Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1362743004: GN: Don't build dist_jar for _incremental targets (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@incremental-deps-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't build dist_jar for _incremental targets It may actually turn out that dist_jar is necessary for tests, but for now *_incremental apks don't work for tests anyways, and building dist_jar slows down the build. BUG=533442 Committed: https://crrev.com/aad19dc0d13604a8e7009dffc2608822fe1a7f4d Cr-Commit-Position: refs/heads/master@{#350456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
pkotwicz
lgtm
5 years, 3 months ago (2015-09-23 18:14:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362743004/1
5 years, 3 months ago (2015-09-24 02:26:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 03:00:08 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 03:01:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aad19dc0d13604a8e7009dffc2608822fe1a7f4d
Cr-Commit-Position: refs/heads/master@{#350456}

Powered by Google App Engine
This is Rietveld 408576698