build/config/android/rules.gni - Issue 1362743004: GN: Don't build dist_jar for _incremental targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/rules.gni

Issue 1362743004: GN: Don't build dist_jar for _incremental targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@incremental-deps-1

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/rules.gni

diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni

index f77d150b9cc37b40b0c0ab408a64ed8767f6d496..2c8c4d66b57f84966f5706bb1de77173fc59301b 100644

--- a/build/config/android/rules.gni

+++ b/build/config/android/rules.gni

@@ -1403,7 +1403,6 @@ template("android_apk") {

if (_dist_jar_path != "") {

create_dist_target = "${_template_name}__create_dist_jar"

_final_deps += [ ":$create_dist_target" ]

- _incremental_final_deps += [ ":$create_dist_target" ]

# TODO(cjhopman): This is only ever needed to calculate the list of tests to

# run. See build/android/pylib/instrumentation/test_jar.py. We should be

« no previous file with comments | « no previous file | no next file » | no next file with comments »