Issue 1362713002: Do not cast Visual State Callback request_id argument to long.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1362713002: Do not cast Visual State Callback request_id argument to long. (Closed)

Created:
5 years, 3 months ago by Tobias Sargeant

Modified:
5 years, 3 months ago

Reviewers:

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

Do not cast Visual State Callback request_id argument to long. The request id is a Java long, and casting to C++ long loses precision. BUG=534864 Review URL: https://codereview.chromium.org/1348473003 Cr-Commit-Position: refs/heads/master@{#350210} (cherry picked from commit 63b8ddb9d1d6f7b504cebdd1980cc037afe1189d) Committed: https://chromium.googlesource.com/chromium/src/+/f8faac340b8fcb525fc1a3ceffacd601801bf7c6

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/native/aw_contents.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/native/aw_contents.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

Tobias Sargeant

5 years, 3 months ago (2015-09-22 20:52:44 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f8faac340b8fcb525fc1a3ceffacd601801bf7c6 (tree was closed).