android_webview/native/aw_contents.h - Issue 1362713002: Do not cast Visual State Callback request_id argument to long.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.h

Issue 1362713002: Do not cast Visual State Callback request_id argument to long. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2490

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.h

diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h

index cbdb8b226a1eabf3c220c86a32f38823bb0db65e..78869ab75a05f244c6232d28cdc456d3b2405b59 100644

--- a/android_webview/native/aw_contents.h

+++ b/android_webview/native/aw_contents.h

@@ -136,7 +136,7 @@ class AwContents : public FindHelper::Listener,

void EnableOnNewPicture(JNIEnv* env, jobject obj, jboolean enabled);

void InsertVisualStateCallback(JNIEnv* env,

jobject obj,

- long request_id,

+ jlong request_id,

jobject callback);

void ClearView(JNIEnv* env, jobject obj);

void SetExtraHeadersForUrl(JNIEnv* env, jobject obj,