Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348473003: Do not cast Visual State Callback request_id argument to long. (Closed)

Created:
5 years, 3 months ago by Tobias Sargeant
Modified:
5 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, boliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not cast Visual State Callback request_id argument to long. The request id is a Java long, and casting to C++ long loses precision. BUG=534864 Committed: https://crrev.com/63b8ddb9d1d6f7b504cebdd1980cc037afe1189d Cr-Commit-Position: refs/heads/master@{#350210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tobias Sargeant
5 years, 3 months ago (2015-09-22 18:07:09 UTC) #1
boliu
lgtm
5 years, 3 months ago (2015-09-22 18:07:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348473003/1
5 years, 3 months ago (2015-09-22 18:09:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 19:20:13 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:22:01 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/63b8ddb9d1d6f7b504cebdd1980cc037afe1189d
Cr-Commit-Position: refs/heads/master@{#350210}

Powered by Google App Engine
This is Rietveld 408576698