Re-land: Add localized default audio device names.

Re-land: Add localized default audio device names.

Original CL here:
https://codereview.chromium.org/1339183002/

The original CL added a media dependency to the chrome/ targets. iOS
builds were failing as a result, because media doesn't yet build on iOS.

This removes the media dependency for iOS.

BUG=497001
Committed: https://crrev.com/c82ba18e50843b4bfecb1238205db4c23b533d91
Cr-Commit-Position: refs/heads/master@{#351213}

[ajm, 2015-09-23 22:27:05]

Patchset #2 (id:20001) has been deleted

[ajm, 2015-09-24 00:21:37]

ajm@chromium.org changed reviewers:
+ dalecurtis@chromium.org, thakis@chromium.org

[ajm, 2015-09-24 00:21:37]

The original CL was reverted due to a failure in media/ on an iOS commit bot. It
wasn't caught in the CQ because the iOS try bots don't build all targets. Filed
a bug for that discrepancy here:
https://code.google.com/p/chromium/issues/detail?id=535257

I repro'd the error locally and this fixes it. Patchset 1 is identical to the
originally landed CL.

[Nico, 2015-09-24 00:37:16]

https://codereview.chromium.org/1362093002/diff/60001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1362093002/diff/60001/media/base/BUILD.gn#new...
media/base/BUILD.gn:299: source_set("media_resources") {
This seems fiddly to me. That's a source_set, so this code now gets linked into
each binary depending on it (so far, that's both chrome.exe and media.dll in
component builds)…

[ajm, 2015-09-24 00:45:39]

https://codereview.chromium.org/1362093002/diff/60001/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/1362093002/diff/60001/media/base/BUILD.gn#new...
media/base/BUILD.gn:299: source_set("media_resources") {
On 2015/09/24 00:37:16, Nico (traveling Tue Sep 22) wrote:
> This seems fiddly to me. That's a source_set, so this code now gets linked
into
> each binary depending on it (so far, that's both chrome.exe and media.dll in
> component builds)…

Yep. It's pretty tiny, and I don't expect it to get much larger (if at all) so I
figured that would be acceptable. Should I make it a component instead? Or do
you see another option?

[Nico, 2015-09-24 00:53:51]

I don't think it's an actual problem in this case, but it kinda sets a bad
precedent.

Do you even need this code in iOS? Can you just sprinkle a few "if !is_ios" into
patch set 1?

[ajm, 2015-09-24 01:46:10]

On 2015/09/24 00:53:51, Nico (traveling Tue Sep 22) wrote:
> I don't think it's an actual problem in this case, but it kinda sets a bad
> precedent.
> 
> Do you even need this code in iOS? Can you just sprinkle a few "if !is_ios"
into
> patch set 1?

I don't need this code in iOS, but that's not the problem. It's that the media
target, which media_resources.cc belongs to in PS1, doesn't build on iOS. Adding
a dependency on media to chrome/ targets pulls it into the iOS build.

Agreed about the bad precedent. I could add a TODO for removing the
media_resources target if media ever builds on iOS. Do you think that would
sufficiently dissuade others from using it as a precedent?

[ajm, 2015-09-24 01:48:54]

On 2015/09/24 01:46:10, ajm wrote:
> I don't need this code in iOS, but that's not the problem. It's that the media
> target, which media_resources.cc belongs to in PS1, doesn't build on iOS.
Adding
> a dependency on media to chrome/ targets pulls it into the iOS build.

Ah, I suppose we could make the build dependency on media conditional, and add
!is_ios around the call-points in chrome/. I guess that was what you meant? :-)

[Nico, 2015-09-24 01:51:41]

right :-)

[ajm, 2015-09-24 01:58:23]

On 2015/09/24 01:51:41, Nico (traveling Tue Sep 22) wrote:
> right :-)

OK, will try that.

[ajm, 2015-09-26 02:38:22]

Nice suggestion, it works fine. PTAL.

Nico, I see that you're "offline until Oct 9" so I'll switch reviewers on
Monday.

[Nico, 2015-09-26 04:28:07]

chrome/ lgtm (and now i'm gone for good, if you need more then you do have to
switch reviewers)

https://codereview.chromium.org/1362093002/diff/100001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/1362093002/diff/100001/chrome/chrome_common.g...
chrome/chrome_common.gypi:73: 'common/media/media_resource_provider.h',
(nit: you could only add those on !ios too, that'd add even more protection than
your ifdef. but as-is is cool too)

[DaleCurtis, 2015-09-27 17:39:26]

media/ lgtm

[ajm, 2015-09-28 22:29:49]

Patchset #6 (id:120001) has been deleted

[ajm, 2015-09-28 22:34:03]

https://codereview.chromium.org/1362093002/diff/100001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/1362093002/diff/100001/chrome/chrome_common.g...
chrome/chrome_common.gypi:73: 'common/media/media_resource_provider.h',
On 2015/09/26 04:28:06, Nico (offline until Fri Oct 9) wrote:
> (nit: you could only add those on !ios too, that'd add even more protection
than
> your ifdef. but as-is is cool too)

True, done.

[ajm, 2015-09-28 22:34:09]

The CQ bit was checked by ajm@chromium.org

[ajm, 2015-09-28 22:34:10]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1362093002/#ps140001
(title: "Exclude media_resource_provider on iOS.")

[commit-bot: I haz the power, 2015-09-28 22:36:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362093002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362093002/140001

[commit-bot: I haz the power, 2015-09-29 00:21:45]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2015-09-29 00:22:21]

Patchset 6 (id:??) landed as
https://crrev.com/c82ba18e50843b4bfecb1238205db4c23b533d91
Cr-Commit-Position: refs/heads/master@{#351213}