Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: media/audio/audio_manager_base.h

Issue 1362093002: Re-land: Add localized default audio device names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Exclude media_resource_provider on iOS. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_manager.cc ('k') | media/audio/audio_manager_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_base.h
diff --git a/media/audio/audio_manager_base.h b/media/audio/audio_manager_base.h
index 346fe47f79bb6ab2b6931f3ba38edd452e12cb16..cd9471316ff2d0953f28cf58ab2f97cf990026f1 100644
--- a/media/audio/audio_manager_base.h
+++ b/media/audio/audio_manager_base.h
@@ -28,17 +28,14 @@ class AudioOutputDispatcher;
// AudioManagerBase provides AudioManager functions common for all platforms.
class MEDIA_EXPORT AudioManagerBase : public AudioManager {
public:
- // TODO(sergeyu): The constants below belong to AudioManager interface, not
- // to the base implementation.
-
- // Name of the generic "default" device.
- static const char kDefaultDeviceName[];
- // Unique Id of the generic "default" device.
+ // TODO(ajm): Move these strings to AudioManager.
+ // Unique Id of the generic "default" device. Associated with the localized
+ // name returned from GetDefaultDeviceName().
static const char kDefaultDeviceId[];
- // Unique Id of the generic default communications device (where supported).
+
+ // Unique Id of the generic default communications device. Associated with
+ // the localized name returned from GetCommunicationsDeviceName().
static const char kCommunicationsDeviceId[];
- // Name of the generic default communications device (where supported).
- static const char kCommunicationsDeviceName[];
// Input device ID used to capture the default system playback stream. When
// this device ID is passed to MakeAudioInputStream() the returned
« no previous file with comments | « media/audio/audio_manager.cc ('k') | media/audio/audio_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698