[Contextual Search] Adds offscreen View rendering capability

[Contextual Search] Adds offscreen View rendering capability.

BUG=535373
Committed: https://crrev.com/bf36900f9414edec57999121162edb5694342f7b
Cr-Commit-Position: refs/heads/master@{#351147}

[pedro (no code reviews), 2015-09-24 00:40:51]

pedrosimonetti@chromium.org changed reviewers:
+ donnd@chromium.org, dtrainor@chromium.org

[pedro (no code reviews), 2015-09-24 00:42:22]

Hey David, please take a look at this change. It adds a helper class with
offscreen View rendering capabilities that will be used in Contextual Search and
Reader Mode (and possibly others that use Views as dynamic resources).

[Theresa, 2015-09-24 17:45:13]

twellington@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2015-09-24 17:45:14]

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java:109:
protected abstract void updateSearchBarTextOpacity(float percentage);
Should we also change updatePromoVisibliity in ContextualSearchPanelBase to
updatePromoOpacity for consistency?

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchTermControl.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchTermControl.java:60:
return false;
Since the view isn't attached the hierarchy, can we get rid of
android:visibility="invisible" in contextual_search_term_view.xml?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
File
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:17:
* inflated is the single child View of the layout (its root).
I think this last sentence is a little unclear. Do you mean that there's only
one top-level View in the XML layout file getting inflated?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:35:
* The id of the XML Layout that describes the view.
nit: for consistency capitalize View in this comment and others throughout the
file.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:113:
assert mView.getId() == mViewId;
Can we just determine the mViewId here instead of requiring it as a constructor
parameter? What do we gain by having the user pass a viewId to the constructor?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:136:
// NOTE(pedrosimonetti): it seems that complex views don't get rendered
Out of curiosity, is a complex view anything that isn't a standalone single view
(e.g. contextual_search_term_view.xml is simple because there's just one
TextView)?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:196:

nit: I think this could be condensed to one line:
https://engdoc.corp.google.com/eng/doc/devguide/java/styleguide.shtml?cl=head...

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:213:
return false;
What's the purpose of attaching a view to the hierarchy temporarily then
detaching? I think maybe it's so that we don't have extra invisible views
attached to the hierarchy.. in which case, should this default to true?

[David Trainor- moved to gerrit, 2015-09-24 17:48:20]

looks good!  Just some nits.  Is this tied to the resource type DYNAMIC?

lgtm

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:32:
public ContextualSearchBarControl(ContextualSearchPanelDelegate panel, Context
context,
fix javadoc

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:34:
* @param viewId            The id of the root View of the Layout.
Could we just grab the id/view we're inflating instead of passing this in?  I
suppose I'll see more when I see the base class :D.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:73:
// When the view is attached, we need to force the layout to have a specific
width
I'm surprised we have to attach this at all?  Can't we do view.measure(),
view.layout(), view.draw()?

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:90:
protected String sanitizeText(String text) {
static?

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:61:
// TODO(pedrosimonetti): DO NOT SUBMIT! testing narrow UI
do not submit! :D

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
File
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:67:
private View mView;
Will mView.getId() match mViewId?  Ah!  Yes according to below.  I guess we need
mViewId in case we need the id before we inflate?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:126:
// View must be inflated at this point.
Could we auto-inflate it here if it wasn't?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:136:
// NOTE(pedrosimonetti): it seems that complex views don't get rendered
That's sad!  I would have hoped/assumed this would work :(.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:196:

remove blank line.

[Donn Denman, 2015-09-24 18:18:18]

LGTM, just some nits.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:19:
private ContextualSearchContextControl mContextControl;
Make final?

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:24:
private ContextualSearchTermControl mSearchTermControl;
Make final?

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:50:
* @param end The portion of the context the selection to its end.
typo, maybe "context from the end of the selection to the end of the context."?

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:42:
Context context, ViewGroup container,
Nit: Are you doing one param per line here?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
File
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:161:
mResourceLoader = null;
Maybe set the IDs to 0 here too?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:169:
assert mView != null;
Seems like these asserts don't really do anything since we'll just crash if null
anyway?

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:188:
return mViewId;
And assert that the ID is not 0 here?

[pedro (no code reviews), 2015-09-25 00:28:23]

Thanks everyone!

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:19:
private ContextualSearchContextControl mContextControl;
On 2015/09/24 18:18:18, Donn Denman wrote:
> Make final?

Done.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:24:
private ContextualSearchTermControl mSearchTermControl;
On 2015/09/24 18:18:18, Donn Denman wrote:
> Make final?

Done.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:32:
public ContextualSearchBarControl(ContextualSearchPanelDelegate panel, Context
context,
On 2015/09/24 17:48:20, David Trainor wrote:
> fix javadoc

Done.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:50:
* @param end The portion of the context the selection to its end.
On 2015/09/24 18:18:18, Donn Denman wrote:
> typo, maybe "context from the end of the selection to the end of the
context."?

I've rephrased to use "before" and "after" which I think it's simpler.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:34:
* @param viewId            The id of the root View of the Layout.
On 2015/09/24 17:48:20, David Trainor wrote:
> Could we just grab the id/view we're inflating instead of passing this in?  I
> suppose I'll see more when I see the base class :D.

We could, but there's one small problem. The resource loader used the View ID as
a identifier, and the View might not be inflated when we render our layer. For
this reason I'm saving a copy of the View ID that is available even when the
view is not inflated. We also use the ID to make sure the inflated View's ID
matches the provided ID.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:42:
Context context, ViewGroup container,
On 2015/09/24 18:18:18, Donn Denman wrote:
> Nit: Are you doing one param per line here?

Yes. Good catch.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:73:
// When the view is attached, we need to force the layout to have a specific
width
On 2015/09/24 17:48:20, David Trainor wrote:
> I'm surprised we have to attach this at all?  Can't we do view.measure(),
> view.layout(), view.draw()?

It will not work for the "Context View" which contains 3 TextViews, 2 of them
with "elastic" width. I've tried many things, and none of them worked.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchInflater.java:90:
protected String sanitizeText(String text) {
On 2015/09/24 17:48:20, David Trainor wrote:
> static?

Done.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java:109:
protected abstract void updateSearchBarTextOpacity(float percentage);
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> Should we also change updatePromoVisibliity in ContextualSearchPanelBase to
> updatePromoOpacity for consistency?

That's a good point, but since updatePromoVisibility() is doing more than just
updating the opacity (it also updates the height of the promo, and the boolean
which keeps track of whether the promo is visible), I think calling it
updatePromoVisibility() makes more sense.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:61:
// TODO(pedrosimonetti): DO NOT SUBMIT! testing narrow UI
On 2015/09/24 17:48:20, David Trainor wrote:
> do not submit! :D

Oops. Sorry, I should have removed this before sending for review.

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchTermControl.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchTermControl.java:60:
return false;
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> Since the view isn't attached the hierarchy, can we get rid of
> android:visibility="invisible" in contextual_search_term_view.xml?

Good point. Done.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
File
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:17:
* inflated is the single child View of the layout (its root).
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> I think this last sentence is a little unclear. Do you mean that there's only
> one top-level View in the XML layout file getting inflated?

Yes. I have rephrased it a little. Let me know if it sounds better. I'm also
open to suggestions to make it clearer.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:35:
* The id of the XML Layout that describes the view.
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> nit: for consistency capitalize View in this comment and others throughout the
> file.

Done.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:67:
private View mView;
On 2015/09/24 17:48:20, David Trainor wrote:
> Will mView.getId() match mViewId?  Ah!  Yes according to below.  I guess we
need
> mViewId in case we need the id before we inflate?

Exactly, since the resource loader requires the View ID as a resource ID, and
the View might not be inflated at that time.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:113:
assert mView.getId() == mViewId;
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> Can we just determine the mViewId here instead of requiring it as a
constructor
> parameter? What do we gain by having the user pass a viewId to the
constructor?

We need it because the resource loader requires the View ID as a resource ID,
and the View might not be inflated at all times.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:126:
// View must be inflated at this point.
On 2015/09/24 17:48:20, David Trainor wrote:
> Could we auto-inflate it here if it wasn't?

I initially had it like you suggested, then I though it would be better to let
it fail, so the consumer knows that it should be inflated first. But I guess it
doesn't hurt auto-inflating here. This would make it simpler for "static"
layouts to be rendered (by "static" I mean those who will not be dynamically
changed).

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:136:
// NOTE(pedrosimonetti): it seems that complex views don't get rendered
On 2015/09/24 17:48:20, David Trainor wrote:
> That's sad!  I would have hoped/assumed this would work :(.

That's sad indeed, but there still might be possible to do it. We need to
investigate further what is causing the problem.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:136:
// NOTE(pedrosimonetti): it seems that complex views don't get rendered
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> Out of curiosity, is a complex view anything that isn't a standalone single
view
> (e.g. contextual_search_term_view.xml is simple because there's just one
> TextView)?

No, Views comprised of multiple Views can be rendered offscreen. What seems to
be causing problem is the layout_gravity: end, possibly in combination of other
things like elastic views (layout_weight: 1) and/or fading edges. Updated the
comment to reflect the new findings.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:161:
mResourceLoader = null;
On 2015/09/24 18:18:18, Donn Denman wrote:
> Maybe set the IDs to 0 here too?

Setting to -1, to make it even clearer that this is an invalid ID.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:169:
assert mView != null;
On 2015/09/24 18:18:18, Donn Denman wrote:
> Seems like these asserts don't really do anything since we'll just crash if
null
> anyway?

The assert is documenting that the View needs to be inflated. If the assert
fails, you will know the line number, and therefore will know that the problem
is not having inflated the View.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:188:
return mViewId;
On 2015/09/24 18:18:18, Donn Denman wrote:
> And assert that the ID is not 0 here?

Done.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:196:

On 2015/09/24 17:45:14, Theresa Wellington wrote:
> nit: I think this could be condensed to one line:
>
https://engdoc.corp.google.com/eng/doc/devguide/java/styleguide.shtml?cl=head...

Thanks for pointing to the documentation. I didn't know that rule.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:196:

On 2015/09/24 17:48:20, David Trainor wrote:
> remove blank line.

Done.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:213:
return false;
On 2015/09/24 17:45:14, Theresa Wellington wrote:
> What's the purpose of attaching a view to the hierarchy temporarily then
> detaching? I think maybe it's so that we don't have extra invisible views
> attached to the hierarchy.. in which case, should this default to true?

Good point. Yes, the quicker we remove it from the hierarchy the better. For
this reason, we should default it to true.

[Theresa, 2015-09-25 01:04:07]

lgtm

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java:109:
protected abstract void updateSearchBarTextOpacity(float percentage);
On 2015/09/25 00:28:23, pedrosimonetti wrote:
> On 2015/09/24 17:45:14, Theresa Wellington wrote:
> > Should we also change updatePromoVisibliity in ContextualSearchPanelBase to
> > updatePromoOpacity for consistency?
> 
> That's a good point, but since updatePromoVisibility() is doing more than just
> updating the opacity (it also updates the height of the promo, and the boolean
> which keeps track of whether the promo is visible), I think calling it
> updatePromoVisibility() makes more sense.

Sounds good to me.

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
File
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java
(right):

https://codereview.chromium.org/1361153004/diff/20001/ui/android/java/src/org...
ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceInflater.java:17:
* inflated is the single child View of the layout (its root).
On 2015/09/25 00:28:23, pedrosimonetti wrote:
> On 2015/09/24 17:45:14, Theresa Wellington wrote:
> > I think this last sentence is a little unclear. Do you mean that there's
only
> > one top-level View in the XML layout file getting inflated?
> 
> Yes. I have rephrased it a little. Let me know if it sounds better. I'm also
> open to suggestions to make it clearer.

It's better :)

[pedro (no code reviews), 2015-09-25 16:20:08]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2015-09-25 16:20:09]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org,
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1361153004/#ps60001
(title: "Sync & rebase")

[commit-bot: I haz the power, 2015-09-25 16:20:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361153004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361153004/60001

[commit-bot: I haz the power, 2015-09-25 17:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 17:57:43]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[pedro (no code reviews), 2015-09-25 19:02:32]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2015-09-25 19:02:33]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org,
dtrainor@chromium.org, twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/1361153004/#ps80001
(title: "Sync & rebase")

[commit-bot: I haz the power, 2015-09-25 19:05:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361153004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361153004/80001

[commit-bot: I haz the power, 2015-09-25 23:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 23:36:10]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[pedro (no code reviews), 2015-09-28 19:37:01]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2015-09-28 19:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org,
dtrainor@chromium.org, twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/1361153004/#ps120001
(title: "Sync & rebase")

[commit-bot: I haz the power, 2015-09-28 19:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361153004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361153004/120001

[commit-bot: I haz the power, 2015-09-28 21:02:31]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-09-28 21:04:10]

Patchset 7 (id:??) landed as
https://crrev.com/bf36900f9414edec57999121162edb5694342f7b
Cr-Commit-Position: refs/heads/master@{#351147}