Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3779)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java

Issue 1361153004: [Contextual Search] Adds offscreen View rendering capability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync & rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
index 59cddb3f67aeeebd63f508895655b339428ac4ba..f58b57c69af868fc6021be9f5ad1dfa3477bcf53 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
@@ -130,14 +130,14 @@ public interface ContextualSearchPanelDelegate {
void removeLastHistoryEntry(String historyUrl, long urlTimeMs);
/**
- * Shows the search term in the BottomBar. This should be called when the search term is set
- * without resolving a search context.
+ * Shows the search term in the SearchBar. This should be called when the search term is set
+ * without search term resolution.
* @param searchTerm The string that represents the search term.
*/
void displaySearchTerm(String searchTerm);
/**
- * Shows the search context in the BottomBar.
+ * Shows the search context in the SearchBar.
* @param selection The portion of the context that represents the user's selection.
* @param start The portion of the context from its start to the selection.
* @param end The portion of the context the selection to its end.
@@ -145,7 +145,7 @@ public interface ContextualSearchPanelDelegate {
void displaySearchContext(String selection, String start, String end);
/**
- * Handles showing the resolved search term in the BottomBarTextControl.
+ * Handles showing the resolved search term in the SearchBar.
* @param searchTerm The string that represents the search term.
*/
void onSearchTermResolutionResponse(String searchTerm);

Powered by Google App Engine
This is Rietveld 408576698