Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2593)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java

Issue 1361153004: [Contextual Search] Adds offscreen View rendering capability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync & rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
index c1ef52d91809d5eb5b8ea7c57dcc7348a6b33014..e7bc0248909ab15ac931d0a3570c438a1b471d1a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java
@@ -97,6 +97,18 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
}
// ============================================================================================
+ // Custom Animations
+ // ============================================================================================
+
+ /**
+ * Updates the UI state for the SearchBar text. The search context view will fade out
+ * while the search term fades in.
+ *
+ * @param percentage The visibility percentage of the search term view.
+ */
+ protected abstract void updateSearchBarTextOpacity(float percentage);
+
+ // ============================================================================================
// Animation API
// ============================================================================================
@@ -366,7 +378,7 @@ public abstract class ContextualSearchPanelAnimation extends ContextualSearchPan
} else if (prop == Property.PROMO_VISIBILITY) {
setPromoVisibilityForOptInAnimation(value);
} else if (prop == Property.BOTTOM_BAR_TEXT_VISIBILITY) {
- updateBottomBarTextVisibility(value);
+ updateSearchBarTextOpacity(value);
}
}

Powered by Google App Engine
This is Rietveld 408576698