Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1361103002: [field type tracking] Fix handling of cleared WeakCells (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[field type tracking] Fix handling of cleared WeakCells Whenever a generalization is computed, the inputs must be checked for being cleared, and if they are, the generalization must be Type::Any. Hopefully this fixes Chromium issue 527994 as well. BUG=v8:4325, chromium:527994 LOG=n Committed: https://crrev.com/afa60ff604bf41cacd08a8364e8a70a2b5f69d30 Cr-Commit-Position: refs/heads/master@{#30887}

Patch Set 1 #

Patch Set 2 : add more --verify-heap checks after object migrations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -32 lines) Patch
M src/accessors.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/lookup.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.cc View 1 12 chunks +58 lines, -25 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-4325.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
PTAL.
5 years, 3 months ago (2015-09-23 11:38:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361103002/20001
5 years, 3 months ago (2015-09-23 11:53:18 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-23 12:17:19 UTC) #6
ulan
LGTM! Good catch.
5 years, 3 months ago (2015-09-23 12:32:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361103002/20001
5 years, 3 months ago (2015-09-23 12:33:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 12:35:25 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:43:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/afa60ff604bf41cacd08a8364e8a70a2b5f69d30
Cr-Commit-Position: refs/heads/master@{#30887}

Powered by Google App Engine
This is Rietveld 408576698