Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: src/lookup.cc

Issue 1361103002: [field type tracking] Fix handling of cleared WeakCells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add more --verify-heap checks after object migrations Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 69b733e6aad2be2aef6b1cecde4573b2a5586c11..809c35e4a5339354bc9dd1bc7cb3e2e9530cbbfc 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -178,6 +178,13 @@ void LookupIterator::ReconfigureDataProperty(Handle<Object> value,
}
ReloadPropertyInformation();
+ WriteDataValue(value);
+
+#if VERIFY_HEAP
+ if (FLAG_verify_heap) {
+ holder->JSObjectVerify();
+ }
+#endif
}
@@ -290,6 +297,12 @@ void LookupIterator::TransitionToAccessorProperty(
}
TransitionToAccessorPair(pair, attributes);
+
+#if VERIFY_HEAP
+ if (FLAG_verify_heap) {
+ receiver->JSObjectVerify();
+ }
+#endif
}
« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698