src/accessors.cc - Issue 1361103002: [field type tracking] Fix handling of cleared WeakCells

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/accessors.cc

Issue 1361103002: [field type tracking] Fix handling of cleared WeakCells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add more --verify-heap checks after object migrations Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/accessors.cc

diff --git a/src/accessors.cc b/src/accessors.cc

index 7d5d27a1da7388d1497178358ccc82db55cf5c96..441ff4d2f54179860b90c1e8128887a62f3a35ac 100644

--- a/src/accessors.cc

+++ b/src/accessors.cc

@@ -1010,7 +1010,6 @@ MUST_USE_RESULT static MaybeHandle<Object> ReplaceAccessorWithDataProperty(

CHECK_EQ(LookupIterator::ACCESSOR, it.state());

DCHECK(it.HolderIsReceiverOrHiddenPrototype());

it.ReconfigureDataProperty(value, it.property_details().attributes());

- it.WriteDataValue(value);

if (is_observed && !old_value->SameValue(*value)) {

return JSObject::EnqueueChangeRecord(object, "update", name, old_value);

« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »