build/android/gyp/util/build_utils.py - Issue 1361013003: Fix build_utils.ExtractAll not respecting pattern parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/util/build_utils.py

Issue 1361013003: Fix build_utils.ExtractAll not respecting pattern parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/util/build_utils.py

diff --git a/build/android/gyp/util/build_utils.py b/build/android/gyp/util/build_utils.py

index 81041ef2f9bf6843e0e00dbbc779db05a34ff5c6..e8729ec8f720829bd8393061620e0b5baef31ed7 100644

--- a/build/android/gyp/util/build_utils.py

+++ b/build/android/gyp/util/build_utils.py

@@ -215,8 +215,7 @@ def ExtractAll(zip_path, path=None, no_clobber=True, pattern=None):

raise Exception(

'Path already exists from zip: %s %s %s'

% (zip_path, name, output_path))

- z.extractall(path=path)

+ z.extract(name, path)

def DoZip(inputs, output, base_dir=None):

« no previous file with comments | « no previous file | no next file » | no next file with comments »