Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1360523002: Cleanup: Pass std::string as const reference from media/ (Closed)

Created:
5 years, 3 months ago by ki.stfu
Modified:
5 years, 3 months ago
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from media/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=dalecurtis@chromium.org,jrummell@chromium.org,sandersd@chromium.org Committed: https://crrev.com/7cc8a91e606147efa653b1d85743052296af757f Cr-Commit-Position: refs/heads/master@{#350046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M media/capture/video/linux/video_capture_device_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/common/transport_encryption_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/common/transport_encryption_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/input_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/input_builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
ki.stfu
5 years, 3 months ago (2015-09-20 20:12:09 UTC) #1
DaleCurtis
lgtm
5 years, 3 months ago (2015-09-21 16:13:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360523002/1
5 years, 3 months ago (2015-09-21 17:17:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43349)
5 years, 3 months ago (2015-09-21 18:30:13 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360523002/1
5 years, 3 months ago (2015-09-21 21:22:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 21:43:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360523002/1
5 years, 3 months ago (2015-09-21 22:12:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 22:21:29 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 22:22:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cc8a91e606147efa653b1d85743052296af757f
Cr-Commit-Position: refs/heads/master@{#350046}

Powered by Google App Engine
This is Rietveld 408576698