Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Side by Side Diff: media/cast/test/utility/input_builder.cc

Issue 1360523002: Cleanup: Pass std::string as const reference from media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cast/test/utility/input_builder.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/test/utility/input_builder.h" 5 #include "media/cast/test/utility/input_builder.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 #include <cstdio> 8 #include <cstdio>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 return input; 56 return input;
57 } 57 }
58 58
59 int InputBuilder::GetIntInput() const { 59 int InputBuilder::GetIntInput() const {
60 std::string string_input = GetStringInput(); 60 std::string string_input = GetStringInput();
61 int int_value; 61 int int_value;
62 CHECK(base::StringToInt(string_input, &int_value)); 62 CHECK(base::StringToInt(string_input, &int_value));
63 return int_value; 63 return int_value;
64 } 64 }
65 65
66 bool InputBuilder::ValidateInput(const std::string input) const { 66 bool InputBuilder::ValidateInput(const std::string& input) const {
67 // Check for a valid range. 67 // Check for a valid range.
68 if (low_range_ == INT_MIN && high_range_ == INT_MAX) 68 if (low_range_ == INT_MIN && high_range_ == INT_MAX)
69 return true; 69 return true;
70 int value; 70 int value;
71 if (!base::StringToInt(input, &value)) 71 if (!base::StringToInt(input, &value))
72 return false; 72 return false;
73 return value >= low_range_ && value <= high_range_; 73 return value >= low_range_ && value <= high_range_;
74 } 74 }
75 75
76 } // namespace test 76 } // namespace test
77 } // namespace cast 77 } // namespace cast
78 } // namespace media 78 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/test/utility/input_builder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698