media/cast/test/utility/input_builder.h - Issue 1360523002: Cleanup: Pass std::string as const reference from media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/test/utility/input_builder.h

Issue 1360523002: Cleanup: Pass std::string as const reference from media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/test/utility/input_builder.h

diff --git a/media/cast/test/utility/input_builder.h b/media/cast/test/utility/input_builder.h

index 4eb4ae52839d812300af36809d58ca1901183cc6..f8ec4d7e0289c0831777b4c0eafd4e292ac4924f 100644

--- a/media/cast/test/utility/input_builder.h

+++ b/media/cast/test/utility/input_builder.h

@@ -33,7 +33,7 @@ class InputBuilder {

int GetIntInput() const;

private:

- bool ValidateInput(const std::string input) const;

+ bool ValidateInput(const std::string& input) const;

const std::string title_;

const std::string default_value_;

« no previous file with comments | « media/cast/test/sender.cc ('k') | media/cast/test/utility/input_builder.cc » ('j') | no next file with comments »