Cleanup: Pass std::string as const reference from gpu/

Cleanup: Pass std::string as const reference from gpu/

Passing std::string by reference can prevent extra copying of object.

BUG=367418
TEST=
R=piman@chromium.org,sievers@chromium.org

Committed: https://crrev.com/8100dae5e20fc6d8ca2fec9258277f189c434164
Cr-Commit-Position: refs/heads/master@{#350063}

[no sievers, 2015-09-21 20:03:06]

https://codereview.chromium.org/1360513002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1360513002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13841: void
GLES2DecoderImpl::ProduceTextureRef(const std::string& func_name,
hmm that doesn't compile does it? the call sites pass in a string constant, so
somewhere we need to create a std::string from it.
can we just change the arg to 'const char*'?

[ki.stfu, 2015-09-21 21:27:15]

https://codereview.chromium.org/1360513002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1360513002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13841: void
GLES2DecoderImpl::ProduceTextureRef(const std::string& func_name,
On 2015/09/21 20:03:06, sievers wrote:
> hmm that doesn't compile does it? the call sites pass in a string constant, so
> somewhere we need to create a std::string from it.
> can we just change the arg to 'const char*'?

You're right. Done.

[ki.stfu, 2015-09-21 21:27:41]

The CQ bit was checked by ki.stfu@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 21:29:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360513002/20001

[commit-bot: I haz the power, 2015-09-21 21:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 21:29:43]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[no sievers, 2015-09-21 21:50:29]

lgtm

[ki.stfu, 2015-09-21 22:22:37]

The CQ bit was checked by ki.stfu@gmail.com

[commit-bot: I haz the power, 2015-09-21 22:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360513002/20001

[commit-bot: I haz the power, 2015-09-21 23:40:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-21 23:42:37]

Patchset 2 (id:??) landed as
https://crrev.com/8100dae5e20fc6d8ca2fec9258277f189c434164
Cr-Commit-Position: refs/heads/master@{#350063}