Cleanup: Pass std::string as const reference from gpu/

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stdio.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 1036 matching lines @@
   void DoTexStorage2DEXT(
       GLenum target,
       GLint levels,
       GLenum internal_format,
       GLsizei width,
       GLsizei height);
 
   void DoProduceTextureCHROMIUM(GLenum target, const GLbyte* key);
   void DoProduceTextureDirectCHROMIUM(GLuint texture, GLenum target,
       const GLbyte* key);
-  void ProduceTextureRef(std::string func_name, TextureRef* texture_ref,
-      GLenum target, const GLbyte* data);
+  void ProduceTextureRef(const std::string& func_name,
+                         TextureRef* texture_ref,
+                         GLenum target,
+                         const GLbyte* data);
 
   void EnsureTextureForClientId(GLenum target, GLuint client_id);
   void DoConsumeTextureCHROMIUM(GLenum target, const GLbyte* key);
   void DoCreateAndConsumeTextureCHROMIUM(GLenum target, const GLbyte* key,
     GLuint client_id);
   void DoApplyScreenSpaceAntialiasingCHROMIUM();
 
   bool DoIsValuebufferCHROMIUM(GLuint client_id);
   void DoBindValueBufferCHROMIUM(GLenum target, GLuint valuebuffer);
   void DoSubscribeValueCHROMIUM(GLenum target, GLenum subscription);
@@ skipping 12760 matching lines @@
 void GLES2DecoderImpl::DoProduceTextureDirectCHROMIUM(GLuint client_id,
     GLenum target, const GLbyte* data) {
   TRACE_EVENT2("gpu", "GLES2DecoderImpl::DoProduceTextureDirectCHROMIUM",
       "context", logger_.GetLogPrefix(),
       "mailbox[0]", static_cast<unsigned char>(data[0]));
 
   ProduceTextureRef("glProduceTextureDirectCHROMIUM", GetTexture(client_id),
       target, data);
 }
 
-void GLES2DecoderImpl::ProduceTextureRef(std::string func_name,
-    TextureRef* texture_ref, GLenum target, const GLbyte* data) {
+void GLES2DecoderImpl::ProduceTextureRef(const std::string& func_name,

[no sievers, 2015/09/21 20:03:06]

hmm that doesn't compile does it? the call sites pass in a string constant, so
somewhere we need to create a std::string from it.
can we just change the arg to 'const char*'?

[ki.stfu, 2015/09/21 21:27:15]

You're right. Done.

+                                         TextureRef* texture_ref,
+                                         GLenum target,
+                                         const GLbyte* data) {
   const Mailbox& mailbox = *reinterpret_cast<const Mailbox*>(data);
   DLOG_IF(ERROR, !mailbox.Verify()) << func_name << " was passed a "
                                        "mailbox that was not generated by "
                                        "GenMailboxCHROMIUM.";
 
   if (!texture_ref) {
     LOCAL_SET_GL_ERROR(
         GL_INVALID_OPERATION, func_name.c_str(), "unknown texture for target");
     return;
   }
@@ skipping 1186 matching lines @@
   return error::kNoError;
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu