gpu/tools/compositor_model_bench/render_tree.cc - Issue 1360513002: Cleanup: Pass std::string as const reference from gpu/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/tools/compositor_model_bench/render_tree.cc

Issue 1360513002: Cleanup: Pass std::string as const reference from gpu/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass func_name as const char* in GLES2DecoderImpl::ProduceTextureRef Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/tools/compositor_model_bench/render_tree.cc

diff --git a/gpu/tools/compositor_model_bench/render_tree.cc b/gpu/tools/compositor_model_bench/render_tree.cc

index f2369df18ef6650e4aa233a30cc1114db94cd049..e1a3804b99307004006dd508ef45beff8374b632 100644

--- a/gpu/tools/compositor_model_bench/render_tree.cc

+++ b/gpu/tools/compositor_model_bench/render_tree.cc

@@ -23,7 +23,7 @@ using base::ReadFileToString;

using std::string;

using std::vector;

-GLenum TextureFormatFromString(std::string format) {

+GLenum TextureFormatFromString(const std::string& format) {

if (format == "RGBA")

return GL_RGBA;

if (format == "RGB")

« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.h ('k') | gpu/tools/compositor_model_bench/shaders.h » ('j') | no next file with comments »